mirror of
https://github.com/outline/outline.git
synced 2026-08-03 13:27:25 +03:00
* Reduce server memory usage and add container memory best practices Profiling a full-service boot showed ~300MB RSS per service process, much of it client-only dependencies pulled into the server module graph, and no heap limits applied in containers: - Import date-fns locales individually rather than via the locale index, which loaded all ~90 locales into every process - Load @sentry/react dynamically in insertFiles so the browser Sentry SDK stays out of the server-side editor graph - Replace class-validator isHexColor with the existing validateColorHex in the Highlight mark - Extract icon names into a standalone IconNames module so server-side schema validation no longer imports Font Awesome icon packs, with a test to keep it in sync with IconLibrary - Require S3Storage lazily so the AWS SDK and native CRT binding are only loaded when S3 file storage is configured - Default each forked service process to a V8 heap limit derived from the cgroup memory constraint, preventing several processes from together committing more memory than the container allows - Cap glibc malloc arenas in the Docker image to reduce resident memory fragmentation in multi-threaded processes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa * Require both file storage backends lazily for consistency Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa * Load AWS SDK via dynamic imports compatible with test environment Requiring the storage TypeScript modules lazily broke under Vitest, which cannot resolve require() of source files and does not apply vi.mock to bare requires. Move the laziness into S3Storage instead: the module is imported statically, and the AWS SDK packages are loaded with dynamic imports on first use, including deferred creation of the S3 client. Also address review feedback: handle rejection of the dynamic Sentry import, and warn when the minimum per-process heap limit exceeds the memory budget of the container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa * Consolidate S3 SDK loading into a single lazy accessor The commands are loaded together with the client in getS3() rather than as separate dynamic imports per method. The global S3Client test mock is now a class, as a mock function is not constructable when reached through a dynamic import. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa --------- Co-authored-by: Claude <noreply@anthropic.com>
285 lines
8.1 KiB
TypeScript
285 lines
8.1 KiB
TypeScript
/* oxlint-disable @typescript-eslint/no-misused-promises */
|
|
/* oxlint-disable import/order */
|
|
import { toError } from "@shared/utils/error";
|
|
import env from "./env";
|
|
|
|
import "./logging/tracer"; // must come before importing any instrumented module
|
|
|
|
import http from "node:http";
|
|
import https from "node:https";
|
|
import os from "node:os";
|
|
import type { Context } from "koa";
|
|
import Koa from "koa";
|
|
import helmet from "koa-helmet";
|
|
import logger from "koa-logger";
|
|
import Router from "koa-router";
|
|
import type { AddressInfo } from "node:net";
|
|
import stoppable from "stoppable";
|
|
import throng from "throng";
|
|
import { escape } from "es-toolkit/compat";
|
|
import Logger from "./logging/Logger";
|
|
import services from "./services";
|
|
import { getArg } from "./utils/args";
|
|
import { getSSLOptions } from "./utils/ssl";
|
|
import { defaultRateLimiter } from "@server/middlewares/rateLimiter";
|
|
import {
|
|
printEnv,
|
|
checkPendingMigrations,
|
|
configureChildHeapLimit,
|
|
} from "./utils/startup";
|
|
import { checkUpdates } from "./utils/updates";
|
|
import onerror from "./onerror";
|
|
import ShutdownHelper, { ShutdownOrder } from "./utils/ShutdownHelper";
|
|
import { checkConnection, sequelize } from "./storage/database";
|
|
import Redis from "@server/storage/redis";
|
|
import Metrics from "@server/logging/Metrics";
|
|
import { CacheHelper } from "./utils/CacheHelper";
|
|
import { RedisPrefixHelper } from "./utils/RedisPrefixHelper";
|
|
import { PluginManager } from "./utils/PluginManager";
|
|
|
|
// The number of processes to run, defaults to the number of CPU's available
|
|
// for the web service, and 1 for collaboration unless REDIS_COLLABORATION_URL is set.
|
|
let webProcessCount = env.WEB_CONCURRENCY;
|
|
|
|
if (env.SERVICES.includes("collaboration") && !env.REDIS_COLLABORATION_URL) {
|
|
if (webProcessCount !== 1) {
|
|
Logger.info(
|
|
"lifecycle",
|
|
"Note: Restricting process count to 1 due to use of collaborative service without REDIS_COLLABORATION_URL"
|
|
);
|
|
}
|
|
|
|
webProcessCount = 1;
|
|
}
|
|
|
|
// This function will only be called once in the original process
|
|
async function master() {
|
|
await checkConnection(sequelize);
|
|
await checkPendingMigrations();
|
|
await printEnv();
|
|
|
|
if (env.TELEMETRY && env.isProduction) {
|
|
void checkUpdates();
|
|
setInterval(checkUpdates, 24 * 3600 * 1000).unref();
|
|
}
|
|
}
|
|
|
|
// This function will only be called in each forked process
|
|
async function start(_id: number, disconnect: () => void) {
|
|
// Ensure plugins are loaded
|
|
PluginManager.loadPlugins();
|
|
|
|
// Clear unfurl cache in development so code changes take effect immediately
|
|
if (env.isDevelopment) {
|
|
void CacheHelper.clearData(RedisPrefixHelper.getUnfurlKey(""));
|
|
}
|
|
|
|
// Find if SSL certs are available
|
|
const ssl = getSSLOptions();
|
|
const useHTTPS = !!ssl.key && !!ssl.cert;
|
|
|
|
// If a --port flag is passed then it takes priority over the env variable
|
|
const normalizedPort = getArg("port", "p") || env.PORT;
|
|
const app = new Koa();
|
|
const server = stoppable(
|
|
useHTTPS
|
|
? https.createServer(ssl, app.callback())
|
|
: http.createServer(app.callback()),
|
|
ShutdownHelper.connectionGraceTimeout
|
|
);
|
|
const router = new Router();
|
|
|
|
// install basic middleware shared by all services
|
|
if (env.DEBUG.includes("http")) {
|
|
app.use(logger((str) => Logger.info("http", str)));
|
|
}
|
|
|
|
app.use(helmet());
|
|
|
|
// catch errors in one place, automatically set status and response headers
|
|
onerror(app);
|
|
|
|
// Apply default rate limit to all routes
|
|
app.use(defaultRateLimiter());
|
|
|
|
/** Perform a redirect on the browser so that the user's auth cookies are included in the request. */
|
|
app.context.redirectOnClient = function (
|
|
this: Context,
|
|
/** The URL to redirect to */
|
|
url: string,
|
|
/**
|
|
* The HTTP method to use for the redirect. Use POST when preventing links in emails from being
|
|
* clicked by bots. Otherwise, use GET.
|
|
*/
|
|
method: "GET" | "POST" = "GET"
|
|
) {
|
|
this.type = "text/html";
|
|
|
|
if (method === "POST") {
|
|
// For POST method, create a form that auto-submits
|
|
const urlObj = new URL(url);
|
|
const formAction = `${urlObj.origin}${urlObj.pathname}`;
|
|
const searchParams = urlObj.searchParams;
|
|
|
|
let formFields = "";
|
|
searchParams.forEach((value, key) => {
|
|
formFields += `<input type="hidden" name="${escape(
|
|
key
|
|
)}" value="${escape(value)}" />`;
|
|
});
|
|
|
|
if (this.userAgent.isBot) {
|
|
formFields += `
|
|
<p>If you are not redirected automatically, please click the button below.</p>
|
|
<input type="submit" value="Continue" />
|
|
`;
|
|
}
|
|
|
|
this.body = `
|
|
<html lang="en">
|
|
<head>
|
|
<title>Redirecting…</title>
|
|
</head>
|
|
<body>
|
|
<form id="redirect-form" method="POST" action="${formAction}">
|
|
${formFields}
|
|
</form>
|
|
<script nonce="${this.state.cspNonce}">
|
|
${!this.userAgent.isBot} && document.getElementById('redirect-form').submit();
|
|
</script>
|
|
</body>
|
|
</html>`;
|
|
} else {
|
|
// Default GET method using meta refresh
|
|
this.body = `
|
|
<html lang="en">
|
|
<head>
|
|
<meta http-equiv="refresh" content="0;URL='${escape(url)}'" />
|
|
</head>
|
|
</html>`;
|
|
}
|
|
};
|
|
|
|
// Add a health check endpoint to all services
|
|
router.get("/_health", async (ctx) => {
|
|
try {
|
|
await sequelize.query("SELECT 1");
|
|
} catch (err) {
|
|
Logger.error("Database connection failed", toError(err));
|
|
ctx.status = 500;
|
|
return;
|
|
}
|
|
|
|
try {
|
|
await Redis.defaultClient.ping();
|
|
} catch (err) {
|
|
Logger.error("Redis ping failed", toError(err));
|
|
ctx.status = 500;
|
|
return;
|
|
}
|
|
|
|
ctx.body = "OK";
|
|
});
|
|
|
|
app.use(router.routes());
|
|
|
|
// loop through requested services at startup
|
|
for (const name of env.SERVICES) {
|
|
if (!Object.keys(services).includes(name)) {
|
|
throw new Error(`Unknown service ${name}`);
|
|
}
|
|
|
|
Logger.info("lifecycle", `Starting ${name} service`);
|
|
const { default: init } = await services[name as keyof typeof services]();
|
|
await Promise.resolve(init(app, server as https.Server, env.SERVICES));
|
|
}
|
|
|
|
server.on("error", (err) => {
|
|
if ("code" in err && err.code === "EADDRINUSE") {
|
|
Logger.error(`Port ${normalizedPort} is already in use. Exiting…`, err);
|
|
process.exit(0);
|
|
}
|
|
|
|
if ("code" in err && err.code === "EACCES") {
|
|
Logger.error(
|
|
`Port ${normalizedPort} requires elevated privileges. Exiting…`,
|
|
err
|
|
);
|
|
process.exit(0);
|
|
}
|
|
|
|
throw err;
|
|
});
|
|
server.on("listening", () => {
|
|
const address = server.address();
|
|
const port = (address as AddressInfo).port;
|
|
|
|
Logger.info(
|
|
"lifecycle",
|
|
`Listening on ${useHTTPS ? "https" : "http"}://localhost:${port} / ${
|
|
env.URL
|
|
}`
|
|
);
|
|
});
|
|
|
|
server.listen(normalizedPort);
|
|
server.setTimeout(env.REQUEST_TIMEOUT);
|
|
|
|
ShutdownHelper.add(
|
|
"server",
|
|
ShutdownOrder.last,
|
|
() =>
|
|
new Promise((resolve, reject) => {
|
|
// Calling stop prevents new connections from being accepted and waits for
|
|
// existing connections to close for the grace period before forcefully
|
|
// closing them.
|
|
server.stop((err, gracefully) => {
|
|
disconnect();
|
|
|
|
if (err) {
|
|
reject(err);
|
|
} else {
|
|
resolve(gracefully);
|
|
}
|
|
});
|
|
})
|
|
);
|
|
|
|
ShutdownHelper.add("metrics", ShutdownOrder.last, () => Metrics.flush());
|
|
|
|
// Handle uncaught promise rejections
|
|
process.on("unhandledRejection", (error: Error) => {
|
|
Logger.error("Unhandled promise rejection", error, {
|
|
stack: error.stack,
|
|
});
|
|
});
|
|
|
|
// Handle shutdown signals
|
|
process.once("SIGTERM", () => ShutdownHelper.execute());
|
|
process.once("SIGINT", () => ShutdownHelper.execute());
|
|
}
|
|
|
|
const isWebProcess =
|
|
env.SERVICES.includes("web") ||
|
|
env.SERVICES.includes("api") ||
|
|
env.SERVICES.includes("collaboration");
|
|
|
|
const isWorkerProcess =
|
|
env.SERVICES.length === 1 && env.SERVICES.includes("worker");
|
|
|
|
// Mirrors the `count` passed to throng below, where undefined falls back to
|
|
// throng's default of one process per CPU.
|
|
const processCount = isWorkerProcess
|
|
? 1
|
|
: isWebProcess
|
|
? (webProcessCount ?? os.cpus().length)
|
|
: os.cpus().length;
|
|
|
|
configureChildHeapLimit(processCount);
|
|
|
|
void throng({
|
|
master,
|
|
worker: start,
|
|
count: isWorkerProcess ? 1 : isWebProcess ? webProcessCount : undefined,
|
|
});
|