GitHub/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-08-03 13:27:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Crash opening comment sidebar in Lightbox on public share (#13164)

Browse Source
This commit is contained in:
Tom Moor
2026-07-27 18:15:57 -04:00
committed by GitHub
parent 3260153f9c
commit 854db75995
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/components/Lightbox.tsx
+5 -1
View File
@@ -65,6 +65,7 @@ import { HStack } from "./primitives/HStack";
import { useDocumentContext } from "./DocumentContext";
import LightboxComments from "~/scenes/Document/components/Comments/LightboxComments";
import { PortalContext } from "./Portal";
import useCurrentUser from "~/hooks/useCurrentUser";
import useHideElement from "~/hooks/useHideElement";
import type { Status } from "./LightboxState";
import {
@@ -272,10 +273,13 @@ function Lightbox({ images, activeImage, onUpdate, onClose, readOnly }: Props) {
} | null>(null);
const zoomPanPinchRef = useRef<ReactZoomPanPinchRef>(null);
const editor = useEditor();
const user = useCurrentUser({ rejectOnEmpty: false });
const { document: contextDocument } = useDocumentContext();
const activeNode = editor?.view?.state?.doc?.nodeAt(activeImage.pos);
// Comments are unavailable without a signed in session, for example when
// viewing a publicly shared document.
const canShowComments =
!!contextDocument && activeNode?.type.name === "image";
!!user && !!contextDocument && activeNode?.type.name === "image";
const currentImageIndex = findIndex(
images,