GitHub/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-08-03 13:27:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Recalculate memberships in the same transaction when moving doc (#13182)

Browse Source 
closes #13181
This commit is contained in:
Tom Moor
2026-07-28 17:44:16 -04:00
committed by GitHub
parent 5ff3020318
commit 9b03db016c
1 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/queues/processors/DocumentMovedProcessor.ts
+20 -10
View File
@@ -38,8 +38,8 @@ export default class DocumentMovedProcessor extends BaseProcessor {
: [],
]);
await this.destroyUserMemberships(document.id);
await this.destroyGroupMemberships(document.id);
await this.destroyUserMemberships(document, transaction);
await this.destroyGroupMemberships(document, transaction);
await this.recalculateUserMemberships(
parentDocumentUserMemberships,
@@ -54,27 +54,37 @@ export default class DocumentMovedProcessor extends BaseProcessor {
});
}
private async destroyUserMemberships(documentId: string) {
const document = await Document.findByPk(documentId);
const childDocumentIds = await document.findAllChildDocumentIds();
private async destroyUserMemberships(
document: Document,
transaction: Transaction
) {
const childDocumentIds = await document.findAllChildDocumentIds(undefined, {
transaction,
});
await UserMembership.destroy({
where: {
sourceId: { [Op.ne]: null },
documentId: [...childDocumentIds, documentId],
documentId: [...childDocumentIds, document.id],
},
transaction,
});
}
private async destroyGroupMemberships(documentId: string) {
const document = await Document.findByPk(documentId);
const childDocumentIds = await document.findAllChildDocumentIds();
private async destroyGroupMemberships(
document: Document,
transaction: Transaction
) {
const childDocumentIds = await document.findAllChildDocumentIds(undefined, {
transaction,
});
await GroupMembership.destroy({
where: {
sourceId: { [Op.ne]: null },
documentId: [...childDocumentIds, documentId],
documentId: [...childDocumentIds, document.id],
},
transaction,
});
}