mirror of
https://github.com/outline/outline.git
synced 2026-08-03 13:27:25 +03:00
* Add Slab importer backed by the Markdown import pipeline Slab exports a zip of Markdown documents that is structurally identical to the Outline Markdown export, with one difference: images are referenced as remote signed URLs rather than files inside the archive. Rather than build a parallel importer, this reuses the Markdown task and processor and teaches the shared import pipeline to download remote images: - Enable per-page attachment upload for the Markdown task. The base APIImportTask already downloads remote image/video/attachment URLs and rewrites them to internal redirect URLs; the Markdown task previously opted out because its attachments live in the zip. - Make the base upload step skip URLs that are already internal, so local zip attachments (resolved to redirect URLs during rewriteMarkdown and uploaded from the archive in onAllTasksCompleted) pass through untouched while remote URLs are fetched and re-hosted. Also guards the URL rewrite against nodes not present in the download map. - Introduce IntegrationService.Slab as a distinct, importable service that routes through the Markdown task/processor, so imports are tracked and labelled as "Slab" with no duplicated import logic. - Wire the create API (schema + route), the import settings UI (Slab card and dialog), and a placeholder logo asset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o * Add shell SlabAPIImportTask as a Slab-specific seam Slab imports previously ran through MarkdownAPIImportTask directly. Introduce a thin SlabAPIImportTask subclass so Slab gets its own task name (for scheduling, tracing, and retries) and a dedicated place to override behavior as Slab exports diverge from the generic Markdown shape. The subclass inherits all conversion/attachment/persistence logic and only overrides scheduleNextTask to keep the whole import chain on the Slab class. MarkdownImportsProcessor now selects the task implementation by the import's service when scheduling the first task. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o * Unwrap single root "slab" directory in Slab imports Slab exports wrap the entire workspace in a single top-level directory named "slab". Without handling this, the import produces one "slab" collection containing everything, instead of mapping each workspace area to its own collection. Add a `resolveCollectionRootNodes` seam on the Markdown bootstrap phase (default: pass entries through unchanged) and override it in SlabAPIImportTask to descend into a lone, case-insensitive "slab" root directory so its child directories become collections. Paths are left intact, so the attachment manifest, completion re-walk, and internal-link resolution stay consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o * Use the filename, not the first heading, as the title for Slab imports In Slab a document's leading heading is real content, not its title — the filename is authoritative. Add an `extractTitle` option to DocumentConverter.convert (default true, preserving existing callers) that, when false, skips lifting a leading H1 into the title and leaves it in the body. Expose it through a `shouldExtractTitleFromHeading` seam on the Markdown task and override it in SlabAPIImportTask. With no extracted title, the page falls back to the filename-derived title. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o * Update logo * Narrow MarkdownAPIImportTask generic back to Markdown Slab imports now run through SlabAPIImportTask, so the base Markdown task no longer handles the Slab service directly and its generic can return to Markdown-only. SlabAPIImportTask keeps a Markdown | Slab union on its scheduleNextTask override, which is required so the override stays a valid (contravariant) override of the base's Markdown-typed parameter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o * Optimised images with calibre/image-actions * reorder * Move Slab importer into its own plugin Restructure the Slab importer to live in plugins/slab, mirroring the Notion plugin, instead of being threaded through the core Markdown importer. - plugins/slab/server registers SlabImportsProcessor (Hook.Processor) and SlabAPIImportTask (Hook.Task). The processor extends MarkdownImportsProcessor to claim the Slab service and schedule the Slab task; the task keeps its Slab-specific overrides (remote image download, root "slab" dir unwrap, filename-as-title). - plugins/slab/client registers the Slab import card (Hook.Imports) and owns the import dialog. - Revert MarkdownImportsProcessor to Markdown-only and drop the hardcoded Slab card from the Import settings screen. The Slab service enum, import schema, and create route remain in core, as the Notion plugin's equivalents do. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o * Generalize DropToImport to accept an importable service DropToImport previously branched on `format` to map MarkdownZip/JSON/Slab to specific imports.create calls, with a dead collections.import fallback. Replace this with a single `service` prop and one generic imports.create call. Core no longer hardcodes any service name (notably the Slab plugin service), and the Markdown, JSON, and Slab dialogs each pass their service. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
81 lines
2.2 KiB
TypeScript
81 lines
2.2 KiB
TypeScript
import type { ZipTreeNode } from "@server/utils/ZipHelper";
|
|
import SlabAPIImportTask from "./SlabAPIImportTask";
|
|
|
|
class TestSlabAPIImportTask extends SlabAPIImportTask {
|
|
public resolve(nodes: ZipTreeNode[]): ZipTreeNode[] {
|
|
return this.resolveCollectionRootNodes(nodes);
|
|
}
|
|
|
|
public extractsTitleFromHeading(): boolean {
|
|
return this.shouldExtractTitleFromHeading();
|
|
}
|
|
}
|
|
|
|
const dir = (
|
|
title: string,
|
|
children: ZipTreeNode[] = [],
|
|
pathInZip = title
|
|
): ZipTreeNode => ({
|
|
name: title,
|
|
title,
|
|
pathInZip,
|
|
children,
|
|
});
|
|
|
|
const file = (name: string, pathInZip = name): ZipTreeNode => ({
|
|
name,
|
|
title: name.replace(/\.[^.]+$/, ""),
|
|
pathInZip,
|
|
children: [],
|
|
});
|
|
|
|
describe("SlabAPIImportTask#resolveCollectionRootNodes", () => {
|
|
const task = new TestSlabAPIImportTask();
|
|
|
|
it("unwraps a single root 'slab' directory into its children", () => {
|
|
const eng = dir(
|
|
"Engineering",
|
|
[file("doc.md", "slab/Engineering/doc.md")],
|
|
"slab/Engineering"
|
|
);
|
|
const product = dir(
|
|
"Product",
|
|
[file("spec.md", "slab/Product/spec.md")],
|
|
"slab/Product"
|
|
);
|
|
const root = dir("slab", [eng, product], "slab");
|
|
|
|
expect(task.resolve([root])).toEqual([eng, product]);
|
|
});
|
|
|
|
it("is case-insensitive on the wrapper directory name", () => {
|
|
const child = dir("Team", [file("a.md", "Slab/Team/a.md")], "Slab/Team");
|
|
const root = dir("Slab", [child], "Slab");
|
|
|
|
expect(task.resolve([root])).toEqual([child]);
|
|
});
|
|
|
|
it("leaves multiple root directories untouched", () => {
|
|
const a = dir("Engineering", [file("a.md", "Engineering/a.md")]);
|
|
const b = dir("slab", [file("b.md", "slab/b.md")]);
|
|
|
|
expect(task.resolve([a, b])).toEqual([a, b]);
|
|
});
|
|
|
|
it("leaves a single non-'slab' root directory untouched", () => {
|
|
const a = dir("Engineering", [file("doc.md", "Engineering/doc.md")]);
|
|
|
|
expect(task.resolve([a])).toEqual([a]);
|
|
});
|
|
|
|
it("does not unwrap an empty 'slab' directory", () => {
|
|
const root = dir("slab", []);
|
|
|
|
expect(task.resolve([root])).toEqual([root]);
|
|
});
|
|
|
|
it("does not derive the title from a document's leading heading", () => {
|
|
expect(task.extractsTitleFromHeading()).toBe(false);
|
|
});
|
|
});
|